If I try to build Golded+ (github.com 2018-07-10 Download) with MSVC6 I get compile error 2 on line 129 of gdirposx.cpp. If I revert this code back to the last source backup I have for Golded+ (sf.net CVS) as "long" vice "intptr_t" at
the beginning of line 129, it works all the way thru with no obvious problems reading or writing live messages with the resultant binary GedWin.Exe.
I assume that there is probably more to this error than meets the eye,
so I will wait for clarification before I distribute anything. :)
If I try to build Golded+ (github.com 2018-07-10 Download) with
MSVC6 I get compile error 2 on line 129 of gdirposx.cpp. If I
revert this code back to the last source backup I have for
Golded+ (sf.net CVS) as "long" vice "intptr_t" at
the beginning of line 129, it works all the way thru with no
obvious problems reading or writing live messages with the
resultant binary GedWin.Exe.
I assume that there is probably more to this error than meets the
eye, so I will wait for clarification before I distribute
anything. :)
intptr_t was introduced with the C99 standard which MSVC6 didn't
support.
And at some point since MSVC6 was released, Microsoft changed the
return value of _findfirst() from long to intptr_t.
At the start of gdirposx.cpp you could add something like:
#if _MSC_VER <= 1200
typedef long intptr_t;
#endif
Where 1200 is the internal version number for the C/C++ compiler
provided with MSVC6.
Your code snippet worked perfectly, thank you! Should I submit this as
a forked mod pull request at github?
I have a cosmetic issue when starting gedwin.exe when the screen is
set to 80 columns. The resultant "buf" for part of the startup screen
is too big for 80 columns so it shows as blank (my golded.h is a bit fancy). :( Though the startup of Golded is so fast one seldom sees the startup screen, it IS still wrong in my case {chuckle}.
Could you please send me your golded.h as an attachment. My email
address is below (change "at" to @, "dot" to . and remove spaces).
I have a cosmetic issue when starting gedwin.exe when the screen is set
to 80 columns. The resultant "buf" for part of the startup screen is too big for 80 columns so it shows as blank (my golded.h is a bit fancy). :( Though the startup of Golded is so fast one seldom sees the startup screen, it IS still wrong in my case {chuckle}.
I have modified my version of gedinit.cpp to fix this if anyone is interested? I am not a C programmer (I do assembly and power basic) but
I think I got it close to what is expected for C++. I can send the modified file or attempt to fork, mod & request a pull using github
(never did that either lol).
It has been extensively tested, works fine and doesn't break anything.
I used a
waitkey() to temporarily pause and verify the startup screen :)
13 Jul 18 19:25, you wrote to all:
I have a cosmetic issue when starting gedwin.exe when the screenYou could probably just paste the patch here if you don't want to go
is set to 80 columns. The resultant "buf" for part of the startup
screen is too big for 80 columns so it shows as blank (my
golded.h is a bit fancy). :( Though the startup of Golded is so
fast one seldom sees the startup screen, it IS still wrong in my
case {chuckle}.
to the trouble of forking it on Github.
BTW something is adding CRs to your messages in between paragraphs...
13 Jul 18 19:25, you wrote to all:
I have modified my version of gedinit.cpp to fix this if anyoneIf you're using git from the command-line you can run:
git diff
to provide a patch, using your modified gedinit.cpp.
You could probably just paste the patch here if you don't want to go
to the trouble of forking it on Github.
BTW something is adding CRs to your messages in between paragraphs...
Sysop: | sneaky |
---|---|
Location: | Ashburton,NZ |
Users: | 2 |
Nodes: | 8 (0 / 8) |
Uptime: | 51:52:30 |
Calls: | 2,119 |
Files: | 11,149 |
D/L today: |
2 files (87K bytes) |
Messages: | 952,783 |